search

TheMangoFactory / bakehouse

Streamlines web pre-processors for Spring resources
http://themangofactory.github.com/bakehouse
21 stars 4 forks source link

Unable to get simple javascript concat working #18

Open dwelch2344 opened 11 years ago

dwelch2344 commented 11 years ago

Spent a few hours today kicking the tires and looking under the hood. Looks like a well planned API and I like the way all the pieces fit together, but I can't seem to get a simplified version running.

Should this work out of the box? Or is this mostly just stub code?

I pushed my repo if you want to take a look. I've got a simple config and jsp tag where the relevant parts are.

martypitt commented 11 years ago

Just a ping to advise the new url of the project

dwelch2344 commented 11 years ago

Not sure I follow… oh! Did you move this from your account to TheMangoFactory org?

martypitt commented 11 years ago

Yeah, used to be at github.com/martypitt , now at github.com/themangofactory

Github don't set up redirects, so I was just advising of the change, in case you were visitng an old Url. (Sorry if all I've achieved is creating confusion!)

dwelch2344 commented 11 years ago

No worries! I appreciate it. Transparency is always a nice thing on github :)

martypitt commented 11 years ago

I took a quick look -- there's a bunch of stuff you're doing that I haven't tested (using bakehouse within a tag, using java-driven config).

There's no explicit reason that this stuff shouldn't work though.

I've cloned your repo, but launching the web app has no effect -- looks like you're missing a web.xml in your repo -- can you please push one?

dwelch2344 commented 11 years ago

Servlet 3 doesn't require a web.xml. If you use tomcat 7 (I'm using 7.35 I believe) it should auto detect.

Good point on the tag. I did end up modifying the filemanager to take the servlet context as a parameter to get around the missing webappContext.

Ill dig in more later tonight. Thanks!

Sent from my iPhone

On Feb 9, 2013, at 3:24 PM, martypitt notifications@github.com wrote:

I took a quick look -- there's a bunch of stuff you're doing that I haven't tested (using bakehouse within a tag, using java-driven config).

There's no explicit reason that this stuff shouldn't work though.

I've cloned your repo, but launching the web app has no effect -- looks like you're missing a web.xml in your repo -- can you please push one?

— Reply to this email directly or view it on GitHubhttps://github.com/TheMangoFactory/bakehouse/issues/18#issuecomment-13339975..

martypitt commented 11 years ago

Servlet 3 doesn't require a web.xml. If you use tomcat 7

Neat!

I noticed the changes around removing reference to WebApplicationContext. I thought it was a great idea, so I've updated to remove the dependency. It's pushed to master.

dwelch2344 commented 11 years ago

Awesome. Yeah, I had to rework things since the tag was compiled when the app launched and the DispatcherServlet wasn't around to look up the WebApplicationContext. I like how it ended up tho.

Unfortunately I didn't get any time tonight to take a look, but I realized I didn't clearly state my most prominent question: what should I be seeing from that sample in the template?

Should I only get the 1 concatenated JavaScript file? Or should I see multiple entries?

martypitt commented 11 years ago

You should see two files... One that's concatenated, and another for the angular file you're not serving from a cdn.