search

TheOddler / FactorioWorld

A mod for factorio that changes the map into a real-world map.
25 stars 3 forks source link

New Pull Request soon #18

Closed HySpeed closed 2 years ago

HySpeed commented 3 years ago

Hi, I'm in the final testing of a new version of FactorioWorld. I made changes to my Cities of Earth and want to put some of them into the parent. :)

The changes to FactorioWorld are:

  1. New map created - 'Earth Pacific'. This version switches the two continents, putting Africa on the left, America to the right. This gives the option to connect Russia and Alaska via land bridge in a 'non-Repeat' setup.
  2. Renamed 'World' to 'Earth Atlantic'.
  3. Re-did the spawns to align on either world.
  4. Changed setting 'detailed' / 'large' to be included in a new drop-down: World.
  5. Restructured some files / folders.

I followed your documentation to download a new map of Earth. I then edited it to switch the continents and used your map conversion tool to create the new files. Yes - your tool got used and it worked. :)

thanks, jon

TheOddler commented 3 years ago

Hey HySpeed!

Awesome! Looking forward to PR.

Good to hear that my tool still works :D

Kind regards,

HySpeed commented 3 years ago

I get an error that I am not authorized to write to the repo. I know you sent me an invite a while ago but I think that expired. Can you invite me again? thanks

TheOddler commented 2 years ago

You still need to accept the invite: https://github.com/TheOddler/FactorioWorld/invitations

You can also fork the repo (top right here in GitHub) and, then do you changes there, and create a new PR from there: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

HySpeed commented 2 years ago

Hmm, it is telling me the invitation has expired:     This invitation has expired.      I'm not sure how that stuff works.

jon

On Friday, August 27, 2021, 03:05:13 AM EDT, Pablo Bollansée ***@***.***> wrote:

You still need to accept the invite: https://github.com/TheOddler/FactorioWorld/invitations

You can also fork the repo (top right here in GitHub) and, then do you changes there, and create a new PR from there: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

TheOddler commented 2 years ago

I made a new invite. Try again ;)