TheRedBrain / rpg-inventory

MIT License
1 stars 0 forks source link

Inserting an Item Onto an Offhand Slot with a Two-Handed Weapon on Main Hand, Then Unsheathing, Deletes the Offhand Item #9

Closed InputandOutput closed 2 months ago

InputandOutput commented 3 months ago

Equiping a two-handed weapon onto the mainhand and an offhand item deletes the offhand item after unsheathing. Should there be a forced unequip/drop of the offhand item when unsheathing/unequiping (or some other solution that doesn't involve losing a precious item)?

TheRedBrain commented 3 months ago

What kind of two-handed weapon are you talking about?

is it in the "two_handed_items" item tag?

or is the "two_handed" field in the weapon_attribute file set to true?

InputandOutput commented 3 months ago

It is kinda a bit of both: the two-handed tag applied to a weapon (i.e. an arcane staff) versus two-handed weapons that I haven't edited (i.e. simply sword's katanas). Note that "are_hand_items_restricted_to_item_tags" is set to false.

TheRedBrain commented 3 months ago

when do items get deleted? When you equip the arcane staff or the katana?

Kireandd commented 2 months ago

If the item is two handed and you slot it in the offhand (/shield icon) slot, happens the moment you unsheath

Kireandd commented 2 months ago

https://streamable.com/e7cxtx

TheRedBrain commented 2 months ago

Two handed weapon getting deleted when in the offhand has happened before. Like a year ago, where Better Combat interacted with other mods.

I'll investigate, maybe I can fix it on my end or at least find the issue.

Also, are you using Fabric or Forge? iirc the last time it happened on Forge

Kireandd commented 2 months ago

I'm on Fabric

TheRedBrain commented 2 months ago

yeah the issue had nothing to do with Better Combat, I basically mixed up two values it should be fixed now :)

Kireandd commented 2 months ago

Awesome, cheers!