TheresAFewConors / Sooty

The SOC Analysts all-in-one CLI tool to automate and speed up workflow.
GNU General Public License v3.0
1.34k stars 209 forks source link

Fixing a library issue and created a parser template #35

Closed naveci closed 4 years ago

naveci commented 4 years ago

Description

Fixed a problem in reference to some packages used. Also introduced a github workflow (linting_check.yaml) that will lint the code after submitting it to github. This way, there should be more alerts triggered to syntax issues or problems with referring to packages.

Does this fix a known existing bug under Issues?

Nothing mentioned under issues currently. However, bug can happen with the following functions: urlDecoder safelinksDecoder phishingMenu emailTemplateGen

This is most likely a result from messing with the packages by several PRs (including my own when it comes to tkinter). Linting this correctly reveals the error. Hence why this PR also includes the workflow.

Type of Change

Please delete any options that do not apply here:

Any further info related to the addition

TheresAFewConors commented 4 years ago

Hey @naveci thanks for opening another PR, would you be able to update the template with specifically what these changes do? I'll be able to create a corresponding case to track the features then.

Cheers!

naveci commented 4 years ago

Updated the description.