search

TheresAFewConors / Sooty

The SOC Analysts all-in-one CLI tool to automate and speed up workflow.
GNU General Public License v3.0
1.3k stars 205 forks source link

Added options for URLScan results #65

Closed jenetiks closed 3 years ago

jenetiks commented 3 years ago

Added option for public and private URLScan's see Issue #62

Description

Added option for users to choose public or private scans for URLScan.io

Does this fix a known existing bug under Issues?

No fixes

Type of Change

Please delete any options that do not apply here:

Any further info related to the addition

Sorry, i got bored at work and figured I'd jimmy something up

jenetiks commented 3 years ago

I can work on getting those changes in today and subs for review.

And thanks :)

On Sat, Oct 24, 2020, 21:36 TheresAFewConors notifications@github.com wrote:

@TheresAFewConors requested changes on this pull request.

I like the idea here, as far as the implementation goes I think it would be best to save the user option to a file and instead offer a toggle option for privacy, rather than ask on each request.

Good addition here. It solves a couple of open issues too.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TheresAFewConors/Sooty/pull/65#pullrequestreview-516317972, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7QITNXJEYKTTZNYVLXGJTSMN6IFANCNFSM4S43VYFA .

jenetiks commented 3 years ago

Submitting a new PR for this (sorry) I nuked that old fork like a terd.

jenetiks commented 3 years ago

Closed PR, new open #67