Added options for URLScan results [New]

TheresAFewConors / Sooty

The SOC Analysts all-in-one CLI tool to automate and speed up workflow.

GNU General Public License v3.0

1.34k stars 209 forks source link

Added options for URLScan results [New] #67

Closed jenetiks closed 3 years ago

jenetiks commented 3 years ago

Description

Made desired changes to URLScan options: default = private and option to set to public in config file.

Does this fix a known existing bug under Issues?

Nope

Type of Change

Please delete any options that do not apply here:

[ ] New Feature

Any further info related to the addition

Can close old PR bc I'm a terd.

TheresAFewConors commented 3 years ago

Its looking good - would you be able to add an option to switch from public to private too without having to modify the .yaml file? A simple 1 for pub / 2 for priv would suffice I would think.

After that I think this would be perfect for merging.

jenetiks commented 3 years ago

Sure can

On Sun, Oct 25, 2020, 11:46 TheresAFewConors notifications@github.com wrote:

@TheresAFewConors requested changes on this pull request.

reviewed - requested toggle in cli to switch between pub and priv.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TheresAFewConors/Sooty/pull/67#pullrequestreview-516371755, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7QITOYRAVBWN4PXGIZ2U3SMRB3VANCNFSM4S6MQ67A .

jenetiks commented 3 years ago

Changes are up. Without modifying more of the app, I think we have to keep the prompt within the function itself. If you're okay with more modification, I can muck around to have it prompt once and only once. But I think the small prompt on every scan is sufficient and not too cumbersome on users. Open to ideas though :D