search

ThomasBarth / ESP32-CAN-Driver

CAN driver project for the Espressif ESP32
280 stars 77 forks source link

Patch 2 #14

Open worker2345234 opened 6 years ago

worker2345234 commented 6 years ago

Now it should the speedup work and the patch compile. Sorry, I'm new at github and I transfer the patches manually from my own project to the online repo.

ThomasBarth commented 6 years ago

I would prefer having the pxHighPriWoken as an optional pointer to CAN_read_frame. The return value could be a bit confusing as the user might expect something like worked/didnt work. Having an optional pointer is a better API I think.

void CAN_read_frame(BaseType_t* fYieldRequired) or similar

worker2345234 commented 6 years ago

here we go...

nikeee commented 5 years ago

What's the status on this? I know it has been a long time.

hackrid commented 4 years ago

how is it going here?