search

ThomasBarth / ESP32-CAN-Driver

CAN driver project for the Espressif ESP32
284 stars 78 forks source link

mainline in esp-idf ? #25

Closed hackrid closed 5 years ago

hackrid commented 5 years ago

Hello,

thanks for your work on this!

what are your thoughts on including this into the main esp-idf project? best regards!

collin80 commented 5 years ago

I don't think that will happen if only because the esp-idf has it's own CAN driver. So, in order to mainline Mr Barth's version you'd have to convince them to abandon their version and use this in it's place. This seems unlikely.

dpharris commented 5 years ago

I had a look at 'theirs' and it looks pretty good.

https://github.com/espressif/esp-idf/blob/master/components/driver/include/driver/can.h and https://github.com/espressif/esp-idf/blob/master/components/driver/can.c

David

On Fri, Jul 26, 2019 at 12:31 PM Collin Kidder notifications@github.com wrote:

I don't think that will happen if only because the esp-idf has it's own CAN driver. So, in order to mainline Mr Barth's version you'd have to convince them to abandon their version and use this in it's place. This seems unlikely.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ThomasBarth/ESP32-CAN-Driver/issues/25?email_source=notifications&email_token=AAEDQSSYBFHSZRCGYVCHRMTQBNGIRA5CNFSM4IHCEEVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD25QJRY#issuecomment-515572935, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEDQSTMUEP2LSQDPI5MZT3QBNGIRANCNFSM4IHCEEVA .

hackrid commented 5 years ago

Hi fellows,

Thanks for your comments. For what ever reason I had the understanding that CAN is not supported in the esp-idf. My initial question is somehow solved then.

Thanks!