ThomasTJdev / nim_websitecreator

Nim fullstack website framework - deploy a website within minutes
https://nimwc.org
MIT License
176 stars 7 forks source link

0.20.2 #110

Closed juancarlospaco closed 5 years ago

juancarlospaco commented 5 years ago

I really wanted to add Backups for DB and option to disable Recaptcha was asked by lots of people, because Recaptcha wont work over Tor or certain countries (like Cuba, etc).

:slightly_smiling_face:

ThomasTJdev commented 5 years ago

Great work so far @juancarlospaco

ThomasTJdev commented 5 years ago

@juancarlospaco are we soon ready to update to Nim 0.20.0?

juancarlospaco commented 5 years ago

Few days I hope, worse case scenario before next month. Sorry I been sending improvements to Nim itself. :slightly_smiling_face:

ThomasTJdev commented 5 years ago

Few days I hope, worse case scenario before next month. Sorry I been sending improvements to Nim itself. 🙂

No problem! I'm happy that you keep working on the PR 😉 Please let me know, if there's something, where you need my help! Otherwise I'll wait until review time due to limited time.

juancarlospaco commented 5 years ago

@ThomasTJdev Let me know any comments. :slightly_smiling_face:

ThomasTJdev commented 5 years ago

Where is the file nimwcpkg/resources/web/google_recaptcha.nim ?

ThomasTJdev commented 5 years ago

Where is the file nimwcpkg/resources/web/google_recaptcha.nim ?

Ahh it's the nim-html-tools. I'm really in doubt about that package. It removes some fundamental functions from NimWC, such as recaptcha, which the plugins also could use and that causes a break. The nim-html-tools package is furthermore specified for NimWC (such as statusIntToText), but I don't see the benefit of splitting NimWC across multiple packages, when we are talking about less than 100 lines of code, which is required by NimWC core - it's not optional code.

I will re-insert the following code into NimWC since it is NimWC-specific + reCaptcha:

Furthermore, I think we shall roll back on inputEmailHtml, inputNumberHtml, etc. and keep them in clean HTML inside NimWC.

EDIT Changed to from html_tools import notifyHtml, rst2html

ThomasTJdev commented 5 years ago

Hi @juancarlospaco

I'm done testing. I have spinned it up on a production server and everything works flawless.

I don't have any further comments - ready for merging.

ThomasTJdev commented 5 years ago

Error on clean install with no plugins and accessing "Installed plugins"

Fixed in c024cdf

juancarlospaco commented 5 years ago

Merging... :slightly_smiling_face: :+1: