search

ThomasTJdev / nim_websitecreator

Nim fullstack website framework - deploy a website within minutes
https://nimwc.org
MIT License
176 stars 7 forks source link

Improve stability of plugin enabling/disabling #117

Open ThomasTJdev opened 5 years ago

ThomasTJdev commented 5 years ago

CC @juancarlospaco, what do you think?

Our recompile function is sometimes unstable. Suggestion:

  1. Activate recompile from the browser UI
  2. NimWC launcher stops nimwc_main subrunner
  3. NimWC launcher moves nimwc_main to a backup location
  4. NimWC launcher runs startupCheck(), which will recompile nimwc_main
  5. If recompiling fails, NimWC launcher will move the backup of nimwc_main back and report the output of the compiling error

Using the method above, we will keep the recompling out of the subrunner, and NimWC launcher will be in control.