search

ThomasTJdev / nim_websitecreator

Nim fullstack website framework - deploy a website within minutes
https://nimwc.org
MIT License
176 stars 7 forks source link

BCrypt --> Argon2 #124

Closed juancarlospaco closed 4 years ago

juancarlospaco commented 4 years ago

https://github.com/Ahrotahn/argon2#detailed :grey_question: :thinking:

ThomasTJdev commented 4 years ago

Looks good, and Argon2 could be a good replacement for bCrypt. But I'm not a fan of 

Argon2 makes use of multiple threads, so the --threads:on flag must be used when compiling your project.

Have you experimented with it?

juancarlospaco commented 4 years ago

I've read the source is very small ~100 line wrapper, very direct wrapper wont do anything for itself, it directly calls Argon2, and it seems Argon2 itself needs threads for everything.

Maybe we can continue using BCrypt, is the second best algo anyways.