search

ThomasTJdev / nim_websitecreator

Nim fullstack website framework - deploy a website within minutes
https://nimwc.org
MIT License
176 stars 7 forks source link

Does not compile against recaptcha@#head #136

Open c-blake opened 3 years ago

c-blake commented 3 years ago

The recaptcha library added a second overload for initRecaptcha. Consequently, nimwcpkg/webs/captchas.nim:setupReCaptcha must provide a third argument (either a bool or a Provider) for Nim to unambiguously resolve the call. This will matter more once recaptcha stamps a new release. You may want a when compiles guard to handle both old & new recaptcha libs.

ThomasTJdev commented 3 years ago

Hi @c-blake

Good catch and thank you!! Actually, I should have noticed this, since I made the PR :dango: https://github.com/euantorano/recaptcha.nim/commit/0c471d24fee645fc50ffa35849a88d1a3ed00e82

c-blake commented 3 years ago

I found it compiling a big chunk of The Nimbleverse to test https://github.com/c-blake/nimp. Nimble uses latest tagged releases while nimp uses #head all the time, really..(or whenever the installer last did nimp up for all their packages).

I started to "patch/fix" said Nimbleverse before deciding to compare how much regular nimble failed - which was "also a lot". :-) The main Nim does important packages CI, but 30-40% of "wider world" packages just break from neglect. { I do not think nimble devs test against the 1350 packages they could. The onus is instead upon package authors to test nimble. }