search

ThomasTJdev / nim_websitecreator

Nim fullstack website framework - deploy a website within minutes
https://nimwc.org
MIT License
176 stars 7 forks source link

Arg to minify CSS and JS #28

Closed ThomasTJdev closed 4 years ago

ThomasTJdev commented 5 years ago

Minify the CSS and JS. Use script.min.js and style.min.css.

(Rename js.js to script.js)

juancarlospaco commented 5 years ago

https://github.com/juancarlospaco/nim-css-html-minify#css-html-minify

ThomasTJdev commented 5 years ago

Is it production ready? Cause then we shall implement it :) !

Do you have a JS minifier in pipeline?

juancarlospaco commented 5 years ago

Javascript can have very weird edge cases that break code and add way too much complexity, in the past I try to do a JS Minifier on Python3, in the end caused so many bugs, like way too much, mainly old and new JS with improper style, in the end I just deprecated the JS support, is impossible to maintain in the long run. I am not adding JS myself. :disappointed:

juancarlospaco commented 4 years ago

I dont know if this should be inside nimwc, most CSS framework provide minified versions, the only minifiers use NodeJS and Java, thats kind of moving the user away from Nim, JavaScript syntax change very quickly and can get really weird, most users will do this aside nimwc anyways. :thinking:

ThomasTJdev commented 4 years ago

You right. I personally use https://github.com/tdewolff/minify in an integrated solution for my website. Let's close this.