search

ThomasTJdev / nim_websitecreator

Nim fullstack website framework - deploy a website within minutes
https://nimwc.org
MIT License
176 stars 7 forks source link

-d:rc Vs -f #60

Closed juancarlospaco closed 5 years ago

juancarlospaco commented 5 years ago

Bug Short Description:

-d:rc is not the same as vanilla -f :grey_question: Nim help says -f, --forceBuild Force rebuilding of all modules. Should we pass -f instead of our custom -d:rc :grey_question:

Operating System:

Choose 1 or more. Mark the checkbox it with an X.

Bug Severity:

Choose only 1. Mark the checkbox it with an X.

Version

Semantic Version of this software the Bug Reproduces into. Type in the Version Number

    5.0.0
ThomasTJdev commented 5 years ago

I have no opinion about the syntax: rc or f. But -f will not do anything different than rc? We still need to manually catch it and recompile, right?

juancarlospaco commented 5 years ago

Both do the same. But if we use a custom -d:rc we have to document it, maintain it, etc. We should pass -f to the nimwc_main and it should do the same as -d:rc theoretically.

ThomasTJdev commented 5 years ago

I'm not totally sure, that I understand.

-d:rc does only tell nimwc.nim's proc startupCheck() to compile nimwc_main.nim. I can't see how passing -f will solve that since nimwc_main is not a module, but an individual file we specify when to compile. https://github.com/ThomasTJdev/nim_websitecreator/blob/37c933c7f65ca451e956b8728a6c7d084f3ac0f8/nimwc.nim#L224-L228

juancarlospaco commented 5 years ago

Oh, maybe you are right.