search

ThomasTJdev / nim_websitecreator

Nim fullstack website framework - deploy a website within minutes
https://nimwc.org
MIT License
176 stars 7 forks source link

UI Improvements #63

Closed juancarlospaco closed 5 years ago

juancarlospaco commented 5 years ago

nimwc-libravatar

See Libravatar Vs Gravatar

Merge it if you agree @ThomasTJdev :cat:

ThomasTJdev commented 5 years ago

Nice with libravatar integration, but I want to keep the possibility for uploading custom photos. On 1 of my website a lot of users does not have libravatar, so they use uploaded pictures.

Can we have both? If no libravatar is available, the standard empty avatar picture is used. User can then choose between uploading picture or using libravatar.

juancarlospaco commented 5 years ago

The possibility for uploading custom photos is back, users can use uploaded pictures, we can we have both:

nimwc-libravatar2

is as you described @ThomasTJdev , feel free to try the UX.

ThomasTJdev commented 5 years ago

This looks great! Good job! I'll test it in the next days.

juancarlospaco commented 5 years ago

I will see if I can improve the UI/UX Im not feeling it, if I get something cooler I will push it here... :thinking:

juancarlospaco commented 5 years ago

Much better UX:

nimwc-libravatar2

nimwc-libravatar

juancarlospaco commented 5 years ago

temp

Installed date comes from the Plugin folder date. Git command is hidden by default.

ThomasTJdev commented 5 years ago

Nice plugin UI! The plugins json should also have a field to specify minimum NimWC version compability.

juancarlospaco commented 5 years ago

https://github.com/ThomasTJdev/nimwc_plugins/issues/2#issue-417501979

juancarlospaco commented 5 years ago

Force normalize filenames on the Files page:

temp2

Plugins Description can be MarkDown/RST/Plain Text on the Plugins page

Quick User Reset for Admins:

temp5

ThomasTJdev commented 5 years ago

1) If it' public website, users could ruin the design by inserting Markdown usernames, e.g. <h1>USERNAME</h1>. I think the username should be normal alphanumeric. What are you thoughts? Why should the username allow Markdown?

2) Should we in future split the PR's per feature?

juancarlospaco commented 5 years ago

temp7

Is the same as the Nim standard library Documentation, but it scapes HTML/SVG/XML, and having only 1 line you can not break too much. Its not like super important anyways, if you prefer to go the opposite only allowing ASCII is Ok. I added a client-side filter pattern to only allow ASCII.

I always meant to do 1 PR per 1 Feature and end up adding more, my bad :rofl: :rofl:

juancarlospaco commented 5 years ago
juancarlospaco commented 5 years ago

:heart_eyes: :+1:

nimwc-temp8

juancarlospaco commented 5 years ago

URLs to try to see the new stuff:

ThomasTJdev commented 5 years ago

Starting test now

ThomasTJdev commented 5 years ago

Really good! The libravatar was a good idea! The new plugin design is great.

ThomasTJdev commented 5 years ago

I have no further review comments. Ready from here. :ship:

juancarlospaco commented 5 years ago

Live Review of NimWC https://www.twitch.tv/videos/391590193?t=01h28m

juancarlospaco commented 5 years ago

Merging :grey_exclamation: :shipit: :ship: