search

ThomasTJdev / nim_websitecreator

Nim fullstack website framework - deploy a website within minutes
https://nimwc.org
MIT License
176 stars 7 forks source link

Check folder permission #65

Closed ThomasTJdev closed 5 years ago

ThomasTJdev commented 5 years ago

When starting files_efs is trying create the standard dirs. If the user does not have access, nimwc will restart and keep trying. Inform user and force a full quit().

juancarlospaco commented 5 years ago

This is by definition, Defensive programming, it should run when not defined(release) IMHO. But :+1: for me.

juancarlospaco commented 5 years ago

I was thinking that this might not worth the effort because imagine a server with 100.000 files and folders, it might looks like NimWC takes years to compile :disappointed:

I prefer to explicitly say on the documentation that the user must check that the program has permission to write on its own folders, and is kinda expected and obvious anyways.

ThomasTJdev commented 5 years ago

1) I was only thinking to check, that the location for storage in config.cfg was writable. Not checking the individual files.

2) Just updating the README.md is fine and maybe the config.cfg with a comment.

juancarlospaco commented 5 years ago

Oh, my bad, I was thinking you wanted a full recursive walk of the folder tree. :slightly_smiling_face: :+1: