ThomasTJdev / nim_websitecreator

Nim fullstack website framework - deploy a website within minutes
https://nimwc.org
MIT License
177 stars 7 forks source link

Add HTML Minify #67

Closed juancarlospaco closed 5 years ago

juancarlospaco commented 5 years ago
ThomasTJdev commented 5 years ago

Ok.

1) Current implementation, resp minifyHtml(genMainAdmin(c, genPlugins(c))), only saves bytes - why use it? 2) When should the user use it? I can only think of plugin-developers.

juancarlospaco commented 5 years ago

Yes, like any Minifier, the bigger the HTML the bigger the saving, but yeah. When you have millions of visits it may worth it, when you have few it may not worth it. I removed it from the routes.nim and leave it to the Plugin developers. :slightly_smiling_face:

juancarlospaco commented 5 years ago

:shipit: :grey_exclamation: