search

ThomasTJdev / nim_websitecreator

Nim fullstack website framework - deploy a website within minutes
https://nimwc.org
MIT License
177 stars 7 forks source link

Simplify files_efs #7

Closed ghost closed 6 years ago

ghost commented 6 years ago

I didn't test it - so can you please do that before merging? And also - do you really need two separate commands? I think they'll do the same thing, the only difference is that the first command will contain absolute path to the fileslocal folder, and second command will contain relative path. Output of the first and second command:

ln -sf /Users/dian/Projects/nim_websitecreator/src/resources/files/fileslocal/* /Users/dian/Projects/nim_websitecreator/src/resources/files/files/efs/

ln -sf fileslocal/* /Users/dian/Projects/nim_websitecreator/src/resources/files/files/efs/
ThomasTJdev commented 6 years ago

Great PR's! Thanks for the improvements!

The reason to absolute and relative path is a mistake. It was while testing with -d:dev, then I didn't have to specify the full path, and when deployed I used a mounted volume. Testing and merging.

ThomasTJdev commented 6 years ago

Implemented - but after a refactory. Thank you for all the PR's!