search

ThomasTJdev / nim_websitecreator

Nim fullstack website framework - deploy a website within minutes
https://nimwc.org
MIT License
176 stars 7 forks source link

Set url to pages from /p/page => /page #86

Closed ThomasTJdev closed 5 years ago

ThomasTJdev commented 5 years ago

Currently a regex is used on pages, and pages needs to include a /p/ in front. It would be more beautiful if the URL was without that, e.g. website.com/faq instead of website.com/p/faq.

https://github.com/ThomasTJdev/nim_websitecreator/blob/f977bbe45eca5abea6710af04aa15193e93051f8/nimwcpkg/resources/web/routes.nim#L966-L969

juancarlospaco commented 5 years ago

This will require a new Release if Fixed, since breaking change.

Kinda Blocked https://github.com/ThomasTJdev/nim_websitecreator/pull/87#issuecomment-475618232

juancarlospaco commented 5 years ago

See https://github.com/ThomasTJdev/nim_websitecreator/pull/87#issuecomment-489006413