Fix #86

[juancarlospaco]

• Fix #86 :smile_cat:

[ThomasTJdev]

Fast 💨 !!

The routes placement needs to be changed. It will eat all the routes below, so they will not be accessible, e.g.:

1. get "/sitemap.xml":
2. All plugin routes

[ThomasTJdev]

Plugin URL's will not be included:

https://github.com/ThomasTJdev/nim_websitecreator/blob/f977bbe45eca5abea6710af04aa15193e93051f8/nimwcpkg/nimwc_main.nim#L526-L537

[juancarlospaco]

I dont know how to fix that, maybe is not so easy...

• This increases the chances of Route collisions a lot.
• Does the breakage worth the improvement :grey_question:
• Whats the problem the /p/ is causing :grey_question: Can we reproduce the problem :grey_question: Or just Cosmetics :grey_question:
• I would prefer https://github.com/ThomasTJdev/nim_websitecreator/pull/74 and https://github.com/ThomasTJdev/nim_websitecreator/pull/88#issue-263674300 to be Merged first, since is less breaky.

This wont work

const pageRoutes = """

get re"/*.":
  createTFD()
  const sql_page = sql"SELECT id FROM pages WHERE url = ?"
  resp genPage(c, getValue(db, sql_page, c.req.path))

"""

macro generateRoutes(): typed =
  var extensions = staticRead("resources/web/routes.nim")

  for ppath in pluginsPath:
    extensions.add("\n\n" & staticRead(ppath & "/routes.nim"))

  extensions.add(pageRoutes)

  result = parseStmt(extensions)

generateRoutes()

:thinking: :thought_balloon:

[ThomasTJdev]

It's purely a cosmetic thing :) . I couldn't find a good solution, so that's why I chose the /p/, which fixed the colliding routes.

[juancarlospaco]

• I can not find anything better than /p/.
• I can not find a way to make Plugin routes work without /p/.

If you have any fix feel free to push here directly.

[juancarlospaco]

I think the breakage and incompatibilities dont worth the cosmetic improvement.

We tried tho, but I want to Close this one, Wont Fix, what do you think @ThomasTJdev :grey_question:

[ThomasTJdev]

I think the breakage and incompatibilities dont worth the cosmetic improvement.

We tried tho, but I want to Close this one, Wont Fix, what do you think @ThomasTJdev ❔

Agree