TiManGames / AmnesiaTheDarkDescent

GNU General Public License v3.0
30 stars 8 forks source link

Warning Suppression and LowLevelSystemSDL Correction #53

Closed Saito720 closed 1 week ago

Saito720 commented 1 week ago

Organized and fixed issues with the MINGW warning suppression options. I also addressed the return statement in "LowLevelSystemSDL.cpp" for the function "FatalError" that contradicts the function's purpose and threw warnings during compilation.

jkulawik commented 1 week ago

What warnings did FatalError() create? Are you sure that adding an exit there won't interrupt the game where it would work otherwise (even if that's how fatal errors should work... but we need to be sure it's how FG actually used it)? Also is that an hpl function or just smth from std?

As to the CMake stuff:

Saito720 commented 1 week ago

Updated "LowLevelSystemSDL.cpp" to have proper indentation and organized "amnesia/src/CMakeLists.txt" warning suppression options.

The reason to keep the change for "FatalError" in "LowLevelSystemSDL.cpp" was explained on Discord in detail. If wanted, the reasoning can be included in the PR as a comment.