CMake Changes

[Saito720]

Description

This commit revises numerous CMake configurations and the Windows cross-compilation toolchain. These revisions primarily enhance consistency and maintainability across the build process.

Key Functional Changes

• Executable Naming: To maintain consistency with other executables and prevent overwriting the original game files, the Launcher and AmnesiaDemo executables are now appended with "CE."
• Static Linking: All executables compiled with MinGW are statically linked with the GCC and C++ runtime, enhancing portability and reducing dependencies on target system libraries.

Additional Updates

• Improved the formatting and clarity of comments within the CMake files.
• Reorganized certain sections of the CMake files to enhance clarity and ease future maintenance.

[jkulawik]

Shouldn't one set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -static-libgcc -static-libstdc++") (in core) be enough? It's repeated 3 times

[Saito720]

Shouldn't one set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -static-libgcc -static-libstdc++") (in core) be enough? It's repeated 3 times

No, the three instances are required (as explained on Discord) due to there being three separate CMake configurations that build all the binaries.

[jkulawik]

Did you test this? add_compile_definitions(-DUSERDIR_RESOURCES) I've had issues with keeping the -D prefix in this function before and had to write it like this add_compile_definitions(USERDIR_RESOURCES)

[Saito720]

Did you test this? add_compile_definitions(-DUSERDIR_RESOURCES) I've had issues with keeping the -D prefix in this function before and had to write it like this add_compile_definitions(USERDIR_RESOURCES)

The appended "-D" did indeed cause compilation issues. So those were addressed and now both Windows and Linux compiles as expected.

I also resolved the one remaining warning for Linux compilation.

Windows:

Linux:

[jkulawik]

For the future, please don't mix broad cosmetic changes/refactors with functional changes.