TidycodeIT / nuxt3-magento-sdk-storefront

A boilerplate storefront build with the Vue Storefront Magento 2 Integration and Storefront UI

https://vuestorefront.io/

30 stars 4 forks source link

Feature/pdp ratings #31

Closed faizanarif121 closed 1 year ago

faizanarif121 commented 1 year ago

Related issue

Closes #25

Scope of work

Make product rating on product display page (product details card dynamic)
Show product reviews under product display page only when they are available
Show ratings on plp page (category page) dynamically

Screenshots of visual changes

Checklist

[x] Self code-reviewed
[ ] Changes documented

rohrig commented 1 year ago

Suggestion: decrease the width of the review card on larger screens.

Would the Review Cards look better if they weren't so wide on larger screens? I'm no designer. You can resolve this without implementing it if you don't like the suggestion.

faizanarif121 commented 1 year ago

Thank you for the PR 😀. I really appreciate your contribution. I've made a few change requests to improve the quality a bit. I'll be happy to merge with those resolved. Thanks in advance.

I really appreciate your kind feedback.

rohrig commented 1 year ago

One more minor change request 😄 . Can you change the constants file to a ts instead of a js extension and nest it in a helpers directory?

faizanarif121 commented 1 year ago

One more minor change request 😄 . Can you change the constants file to a ts instead of a js extension and nest it in a helpers directory?

@rohrig yes, done. I added ts file earlier than changed it back to js :D