Tigge / antfs-cli

Extracts FIT files from ANT-FS based sport watches such as Garmin Forerunner 60, 405CX, 310XT, 610 and 910XT.
MIT License
312 stars 76 forks source link

Use configuration file for logging #116

Closed Toilal closed 9 years ago

Toilal commented 9 years ago

logging could be configured using a configuration file. It would then be easier for users to enable, disable and configure the logging.

Toilal commented 9 years ago

PRODUCT_NAME could be added as a special variable using this answer : http://stackoverflow.com/questions/16203908/how-to-input-variables-in-logger-formatter

Tigge commented 9 years ago

Product name could be usable, but since only once device is active each time the program is run and that information is already present in the log from https://github.com/Tigge/Garmin-Forerunner-610-Extractor/blob/split/antfs-cli.py#L169 I'm not sure including it on every line is necessary.

As long as the log is only a toggle to generate a debug log i think the --debug switch is all that is needed. It could be a bit nice to have configuration options for developers though.

Toilal commented 9 years ago

I think it's not a so good idea, now that log files are written in ~/.config/antfs-cli.

Feel free to close ...

Tigge commented 9 years ago

Could still be implemented in part still, but closing for now.