Use garmin-uploader in upload script

Tigge / antfs-cli

Extracts FIT files from ANT-FS based sport watches such as Garmin Forerunner 60, 405CX, 310XT, 610 and 910XT.

MIT License

312 stars 77 forks source link

Use garmin-uploader in upload script #158

Closed La0 closed 7 years ago

La0 commented 7 years ago

This Pull Request enables the usage of garmin-uploader instead of GCPUploader in the script 40-upload_to_garmin_connect.py. I also added garmin-uploader as an extra depency in setup.py, so a user can install antfs-cli + garmin-uploader in a single command :

sudo pip install antfs-cli[upload]

coveralls commented 7 years ago

Coverage remained the same at 6.272% when pulling b7fa95a0144bae5e55f6f10c33c6a99bfd8344e4 on La0:upload into 8c3b51015889ef8c586ef350384fe018f021efbb on Tigge:master.

Tigge commented 7 years ago

Nice, thank you! It would be great if you could add something to the README file about this as well.

La0 commented 7 years ago

Done !

coveralls commented 7 years ago

Coverage remained the same at 6.272% when pulling f62075a9b469aa607c7dc3f5d4afabe2213e804e on La0:upload into 8c3b51015889ef8c586ef350384fe018f021efbb on Tigge:master.

Echelon9 commented 7 years ago

LGTM

La0 commented 7 years ago

Thanks for the merge !