search

Tigge / antfs-cli

Extracts FIT files from ANT-FS based sport watches such as Garmin Forerunner 60, 405CX, 310XT, 610 and 910XT.
MIT License
312 stars 77 forks source link

scripts: Use local server for Strava auth #180

Closed pwithnall closed 4 years ago

pwithnall commented 4 years ago

Several changes combined into one: • Redirect back to the local server to complete the auth flow, rather than pointlessly redirecting via an AWS server • Convert the temporary token into a long-term token so that people don’t have to reauthenticate every time they want to upload an activity • Don’t use a fixed local port — allow the OS to allocate us one • Store the access and refresh tokens in the correct directory according to the XDG Base Directory specification (https://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html)

I’ve registered a new application with Strava for doing the authentication, since the client secret is needed.

Signed-off-by: Philip Withnall philip@tecnocode.co.uk

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 6.272% when pulling 9fafe4b37d203053a58651d6869f6c446f4d658e on pwithnall:auth into a8ae0ce3d77004bbc1d2c1e7ed34b14c344cddba on Tigge:master.

Tigge commented 4 years ago

Would you mind removing python 3.3 from the Travis config (it's not supported anymore)? It's not something you introduced, but fixing it would give this green checkboxes for the checks.

pwithnall commented 4 years ago

Would you mind removing python 3.3 from the Travis config (it's not supported anymore)? It's not something you introduced, but fixing it would give this green checkboxes for the checks.

Done. Also pushed a commit to refresh the access token.

mscansian commented 4 years ago

@Tigge would you mind merging this? It's a much better fix that what I did on #182 and fixes #178

Tigge commented 4 years ago

Sorry, this got left here without action from me. Merged now. Thank you!