search

Tigge / antfs-cli

Extracts FIT files from ANT-FS based sport watches such as Garmin Forerunner 60, 405CX, 310XT, 610 and 910XT.
MIT License
313 stars 76 forks source link

Only call g.stop() if we are sure g is defined. #66

Closed lamby closed 10 years ago

lamby commented 11 years ago

This prevents "Device not found" exception being masked as a "undefined g".

(I think the real solution is not to do any real hardware access within Garmin.init and then call--say--a "setup" method - that would certainly be the more Pythonic way.)

Signed-off-by: Chris Lamb lamby@debian.org

Tigge commented 11 years ago

Excellent! Could you rebase this on the drivers branch which is where development are currently done? If not I'll rebase and merge this later when I get back from my weekend vaction. Thanks.

aspiers commented 10 years ago

What's the latest on this? Thanks!

Tigge commented 10 years ago

I will merge this to the drivers branch when that gets a bit more stable.

aspiers commented 10 years ago

Any reason not to merge this to master now, regardless of the state of the drivers branch? It's a pretty big usability bug for newcomers.

Tigge commented 10 years ago

True. Will merge.