TileDB-Inc / tiledbsoma-feedstock

A conda-smithy repository for tiledbsoma.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Nightly feedstock build failed #108

Closed github-actions[bot] closed 6 months ago

github-actions[bot] commented 6 months ago

Nightly feedstock build failure for tiledbsoma-feedstock at https://dev.azure.com/TileDB-Inc/CI/_build?definitionId=43&_a=summary

github-actions[bot] commented 6 months ago

Nightly feedstock build failure for tiledbsoma-feedstock at https://dev.azure.com/TileDB-Inc/CI/_build?definitionId=43&_a=summary

jdblischak commented 6 months ago

New solver error for tiledbsoma-py started Saturday night. Almost certainly related to the migration to aws-crt-cpp 0.26.4 https://github.com/conda-forge/tiledb-feedstock/pull/259

    Could not solve for environment specs
    The following packages are incompatible
    ├─ aws-crt-cpp ==0.26.4 h335f1a1_1 is requested and can be installed;
    ├─ libcurl ==8.6.0 hca28451_0 is requested and can be installed;
    ├─ libgoogle-cloud-storage ==2.22.0 hc7a4891_1 is requested and can be installed;
    └─ libtiledbsoma ==1.8.1.dev20240323 hfbc4632_0 is not installable because it requires
       └─ tiledb >=2.20.1,<2.21.0a0  but there are no viable options
          ├─ tiledb 2.20.1 would require
          │  └─ libgoogle-cloud-storage >=2.21.0,<2.22.0a0 , which conflicts with any installable versions previously reported;
          ├─ tiledb 2.20.1 would require
          │  └─ libcurl >=7.88.1,<8.0a0 , which conflicts with any installable versions previously reported;
          ├─ tiledb 2.20.1 would require
          │  └─ aws-crt-cpp >=0.26.2,<0.26.3.0a0 , which conflicts with any installable versions previously reported;
          ├─ tiledb 2.20.1 would require
          │  └─ aws-crt-cpp >=0.26.3,<0.26.4.0a0 , which conflicts with any installable versions previously reported;
          └─ tiledb 2.20.1 would require
             └─ libgoogle-cloud-storage >=2.17.0,<2.18.0a0 , which conflicts with any installable versions previously reported.
jdblischak commented 6 months ago

Note that we don't have a Sunday night build because the setup job failed with a spurious connection failure (#109). I just restarted it

I assume it will still fail. The aws-crt-cpp update to tiledb-feedstock was merged Sunday, but that was for tiledb 2.21. My guess is that we'll need to backport that to tiledb 2.20 to fix the solver error

jdblischak commented 6 months ago

The current solver error should be fixed by the rebuilding of tiledb 2.20 against aws-crt-cpp 0.26.4 (https://github.com/conda-forge/tiledb-feedstock/pull/260, https://github.com/conda-forge/tiledb-feedstock/pull/264, https://github.com/conda-forge/tiledb-feedstock/commit/d85f117f1c0c144959a9b660edc36ab7e1fc066d). If it continues to fail tonight, I want it to open a new Issue

jdblischak commented 6 months ago

Good news! Last night's build passed, which confirms that the problem was letting tiledb 2.20 get stale. Going forward, we need to remember to always backport conda-forge migrations to the current release branch even as we release new versions of libtiledb. The implementation is easy (create a release branch for backporting and add a line in conda-forge.yml); the hard part is remembering to do it.

johnkerl commented 6 months ago

@jdblischak I'll do a writeup in our established procedure and that is how we will remember how to do this

jdblischak commented 6 months ago

I'll do a writeup in our established procedure and that is how we will remember how to do this

I agree this is a good thing to document, since it is such a common source of solver errors.

However, I think that reading it in your TileDB-SOMA release notes would be too late. This needs to be done when conda-forge/tiledb-feedstock is updated to the next minor release, which will happen prior to preparing the next soma release. Fortunately now that the nightly builds open an Issue when they fail, we should be alerted prior to release if we forget to maintain the previous minor release.