search

TileDB-Inc / tiledbsoma-feedstock

A conda-smithy repository for tiledbsoma.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Add a build-time litmus test for the `arrow` R package #128

Closed eddelbuettel closed 2 months ago

eddelbuettel commented 2 months ago

Per a request of @johnkerl a quick test that the arrow R package loads and runs.

johnkerl commented 2 months ago

CI fails are the same as for #127 and are independent of this PR.

johnkerl commented 2 months ago

@jdblischak this LGTM -- since this is a non-recipe PR, do we need to bump the build number in recipe/meta.yaml -- ?

nvm -- I see as precedent https://github.com/TileDB-Inc/tiledbsoma-feedstock/pull/120#issuecomment-2029893320

jdblischak commented 2 months ago

since this is a non-recipe PR, do we need to bump the build number in recipe/meta.yaml -- ?

No, no need to bump the build number. It's not affecting the output binary in any way since it is only a diagnostic for help troubleshooting #126. You'd only need to bump the build number if the update to the build script did something like change a compiler flag

johnkerl commented 2 months ago

https://github.com/single-cell-data/TileDB-SOMA/issues/2414

[sc-44854]