search

TileDB-Inc / tiledbsoma-feedstock

A conda-smithy repository for tiledbsoma.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Update recipe for new `TILEDBSOMA_PATH` handling #13

Closed johnkerl closed 1 year ago

johnkerl commented 1 year ago

As pointed out by @jdblischak on #12 with regard to changes made on https://github.com/single-cell-data/TileDB-SOMA/pull/1189:

https://github.com/single-cell-data/TileDB-SOMA/pull/1189/files#diff-66aed70e28174320f1db4eaccedcab15d85d14b96fb0c2e9f03417e6fc07df92R47

Context: https://github.com/single-cell-data/TileDB-SOMA/issues/1242

jdblischak commented 1 year ago

I'm pretty sure this change needs to be made after the next release of TileDB-SOMA, right? IIUC the current release of the Python client doesn't support TILEDBSOMA_PATH.

Also, I thought the plan under consideration was to allow the Python client to support both strategies, ie the user could set TILEDBSOMA_PATH or use --libtiledbsoma, in which case the conda recipe wouldn't need to be udpated

johnkerl commented 1 year ago

Thanks for the feedback @jdblischak ! :)

johnkerl commented 1 year ago

https://github.com/single-cell-data/TileDB-SOMA/pull/1253 FYI

johnkerl commented 1 year ago

Superseded by https://github.com/single-cell-data/TileDB-SOMA/pull/1253