search

TileDB-Inc / tiledbsoma-feedstock

A conda-smithy repository for tiledbsoma.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Migrate tiledbsoma to spdlog 1.13 #143

Closed jdblischak closed 2 months ago

jdblischak commented 2 months ago

Trying to be one step ahead of the next potential conda solver error. Earlier today tiledb-feedstock was migrated to spdlog 1.13 (https://github.com/conda-forge/tiledb-feedstock/pull/281). This PR does the same for tiledbsoma-feedstock

jdblischak commented 2 months ago

Hmmm...something in the linux-64 R environment also needs to be migrated to spdlog 1.13

Packaging r-tiledbsoma
Reloading output folder (local): ...working... done
Solving environment (_h_env): ...working... failed
WARNING: failed to get package records, retrying.  exception was: Unsatisfiable dependencies for platform linux-64: {MatchSpec("libtiledbsoma==1.10.1=h6216f82_1"), MatchSpec("spdlog[version='>=1.13.0,<1.14.0a0']")}
Encountered problems while solving:
  - package libtiledbsoma-1.10.1-h6216f82_1 requires spdlog >=1.13.0,<1.14.0a0, but none of the providers can be installed

Could not solve for environment specs
The following packages are incompatible
├─ libtiledbsoma 1.10.1.* h6216f82_1 is installable and it requires
│  └─ spdlog >=1.13.0,<1.14.0a0 , which can be installed;
└─ spdlog 1.12.0.* hd2e6256_2 is not installable because it conflicts with any installable versions previously reported
jdblischak commented 2 months ago

I restarted the linux-64 job today. It is still failing with the same solver error as before. Looking at the ongoing spdlog 1.13 migration, I don't see any obvious dependency that would affect the r-tiledbsoma build.

jdblischak commented 2 months ago

I restarted the linux-64 build again today to see if anything has changed for the solver

jdblischak commented 2 months ago

I learned from the recent nightly failure (https://github.com/TileDB-Inc/tiledbsoma-feedstock/issues/146#issuecomment-2088687669) that 1) I wasn't properly migrating the osx-* builds, and 2) the linux-64 r-tiledbsoma build is now ready to migrate to spdlog 1.13

The commit history on this PR is a mess, so we need to squash and merge

jdblischak commented 2 months ago

My only other nagging concern was that conda-smithy 3.35.0, released earlier today, no longer added the C stdlib pins by default. However, I downgraded to conda-smithy 3.34.1 locally, rerendered, and pushed to the nightly branch on my fork, and everything still passed! 🎉

johnkerl commented 2 months ago

Thanks @johnkerl !