search

TileDB-Inc / tiledbsoma-feedstock

A conda-smithy repository for tiledbsoma.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Release TileDB-SOMA 1.2.2 #16

Closed johnkerl closed 1 year ago

jdblischak commented 1 year ago

The nightly Azure builds have been passing

johnkerl commented 1 year ago

@jdblischak thanks for the approval! It'll be another half-hour of runtime before the CI re-completes.

At that point in time, I'll self-merge, given your accept -- is this OK? (I'm still quite new to this repo.)

jdblischak commented 1 year ago

At that point in time, I'll self-merge, given your accept -- is this OK? (I'm still quite new to this repo.)

Eh, if I'm going to be the sole approval, I need to look closer at the upstream changes. Looking at the diff, I noticed two things:

  1. Building for Python 3.11 (the feedstock isn't doing that)
  2. Some fancy numba pinning to deal with Python 3.11

Do you want a Python 3.11 build for version 1.2.2? If yes, you'll need to edit conda_build_config.yaml and then rerender the feedstock. I could also do this for you real quick and push to your branch (assuming you have allowed edits from maintainers for this PR)

johnkerl commented 1 year ago

Thanks for helping me learn, @jdblischak ! I'll put up trial mods & let you double-check them.

johnkerl commented 1 year ago

rerender the feedstock

@jdblischak I will need help on what this means in terms of what a person would actually type :) -- other than googling it (which I have) but I imagine I will still get something wrong

And I'll happily fold whatever you share with me, into content I will post at https://github.com/TileDB-Inc/tiledbsoma-feedstock/wiki

Shelnutt2 commented 1 year ago

Numba does not have a version of 0.57.0rc1 in conda-forge. I believe python 3.11 needs to wait for an official release.

johnkerl commented 1 year ago

Good call and thank you @Shelnutt2 !

jdblischak commented 1 year ago

Numba does not have a version of 0.57.0rc1 in conda-forge. I believe python 3.11 needs to wait for an official release.

Ah, ok. That is a deal breaker. I see on PyPI that 0.57.0rc1 is a pre-release, which I assume explains why there is no PR opened on the numba-feedstock repo

https://pypi.org/project/numba/#history https://github.com/conda-forge/numba-feedstock/pulls

johnkerl commented 1 year ago

@jdblischak @Shelnutt2 3.11 bits have been reverted

jdblischak commented 1 year ago

@johnkerl Here are docs on how to locally rerender a feedstock repo with conda-smithy

https://conda-forge.org/docs/maintainer/updating_pkgs.html#dev-rerender-local

johnkerl commented 1 year ago

@jdblischak @Shelnutt2 good to merge???

jdblischak commented 1 year ago

From a conda recipe perspective, your PR looks good. I also confirmed that the recipe is pinned against the latest TileDB (2.15). I support merging

johnkerl commented 1 year ago

OK @jdblischak it seems @Shelnutt2 is in a meeting. As much as I'd love his final OK (given green CI is insufficient, as I just learned with the manual what-about-3.11 verygoodquestion), I'll go ahead and merge with your confidence.

Thanks!!

johnkerl commented 1 year ago

See also https://github.com/single-cell-data/TileDB-SOMA/issues/1294 which I've taken ownership of