Move past tiledbsoma 1.11.2 workaround

[johnkerl]

157 was necessary in order to complete artifact delivery for 1.11.2.

At head of TileDB-SOMA, the patch there is no longer necessary, and in fact, attempts to apply it break nightlies as at #160.

That said, head as of this moment has at the top of its recipe/meta.yaml

{% set name = "tiledbsoma" %}
{% set version = "1.11.2" %}
{% set sha256 = "e3933c7d7b3d8df59a40ed7833fb20774917f531a915debc76abb569e958a421" %}
...
source:
  url: https://github.com/single-cell-data/TileDB-SOMA/archive/{{ version }}.tar.gz
  sha256: {{ sha256 }}

and this PR (as of the first commit) is failing CI since 1.11.2 does require the patch.

So this repo is trying to serve two masters:

• Latest release tag of TileDB-SOMA -- here 1.11.2 -- does need the patch
• main of TileDB-SOMA -- nightlies -- has moved past 1.11.2 -- needs to not have the patch, and fails if the patch is present

Second attempt https://github.com/TileDB-Inc/tiledbsoma-feedstock/pull/161/commits/0f5c93dc28a63dc4b625d6987a45a6d86b8a70df

[johnkerl]

@jdblischak please see https://github.com/TileDB-Inc/tiledbsoma-feedstock/pull/161/commits/0f5c93dc28a63dc4b625d6987a45a6d86b8a70df -- also I updated the description field of this PR (probably while you were replying in the discussion log).

[jdblischak]

please see https://github.com/TileDB-Inc/tiledbsoma-feedstock/commit/0f5c93dc28a63dc4b625d6987a45a6d86b8a70df -- also I updated the description field of this PR (probably while you were replying in the discussion log).

Correct. I didn't see the new commit and description until after I submitted my review.

I don't think using git_url on main will work because our nightly job script uses sed to replace url: and sha256: with git_url:, git_rev, and git_depth

https://github.com/TileDB-Inc/tiledbsoma-feedstock/blob/3a0d9dc5f9a80d5c4fadf4a5856dfce91c3a5475/.github/scripts/nightly/update-recipe.sh#L13-L21

Do either of these options sound good to you?

• Just merge with failing linux-64 builds on main. We release new versions on this feedstock so regularly, that it is rare that we need to apply a non-version bump change (eg like how we often apply migrations to tiledb-feedstock). In other words, having temporarily failing CI on main isn't going to block us on anything
• If we want to maintain green CI on main and the nightly builds, we can temporarily add some extra sed calls to .github/scripts/nightly/update-recipe.sh to remove the two lines that apply the patch

[johnkerl]

I don't think using git_url on main will work because our nightly job script uses sed to replace url: and sha256: with git_url:, git_rev, and git_depth

Glarg. Thanks ...

If we want to maintain green CI on main and the nightly builds

Really up to you. If you can live with red nightly CI until 1.12.0 pre-check, I can ...

Just merge with failing linux-64 builds on main

This is my preference if you're OK with it. I know how to write sed (for 30 years now) but I don't see the one-off PR work as worth the keystroking.

Third commit: https://github.com/TileDB-Inc/tiledbsoma-feedstock/pull/161/commits/ed003050e6080f35c32829bc77ea6da6d8af9fae

[jdblischak]

Really up to you. If you can live with red nightly CI until 1.12.0 pre-check, I can ...

This isn't a problem for me in this case because I don't envision it causing us other problems

This is my preference if you're OK with it. I know how to write sed (for 30 years now) but I don't see the one-off PR work as worth the keystroking.

Agreed. I don't think it is worth the effort