TileDB-Inc / tiledbsoma-feedstock

A conda-smithy repository for tiledbsoma.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Nightly feedstock build failed #168

Closed github-actions[bot] closed 3 weeks ago

github-actions[bot] commented 4 weeks ago

Nightly feedstock build failure for tiledbsoma-feedstock at https://dev.azure.com/TileDB-Inc/CI/_build?definitionId=43&_a=summary

jdblischak commented 4 weeks ago

All the jobs are failing with the same arrow error during the building of r-tiledbsoma:

** R
** inst
** byte-compile and prepare package for lazy loading
Error in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]]) :
  namespace ‘arrow’ 14.0.1 is being loaded, but >= 15.0.1 is required
Calls: <Anonymous> ... namespaceImportFrom -> asNamespace -> loadNamespace
Execution halted
ERROR: lazy loading failed for package ‘tiledbsoma’
* removing ‘/home/conda/feedstock_root/build_artifacts/tiledbsoma_1717465735283/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/R/library/tiledbsoma’
johnkerl commented 4 weeks ago

@jdblischak https://github.com/single-cell-data/TileDB-SOMA/pull/2679 by @mojaveazure

I'm not sure why 14 is being found ... I'll rerender the feedstock maybe? It's weird b/c our r-arrow in our recipe/meta.yaml has no constraints ...

jdblischak commented 4 weeks ago

I confirmed r-arrow 14.0.1 is the version that is installed in the conda env

     r-arrow:                   14.0.1-r43h59595ed_0          conda-forge

It's weird b/c our r-arrow in our recipe/meta.yaml has no constraints ...

Agreed. I don't see any restrictions on the version in build/host/run or conda_build_config.yaml

I also checked the successful build of 1.11.4 from yesterday's merge commit. It also installed r-arrow 14.0.1. So presumably there is something blocking r-arrow 15+ from being installed

jdblischak commented 4 weeks ago

Well I found the problem. r-arrow 14.0.1 is the most recent version available as a conda binary from conda-forge

https://anaconda.org/conda-forge/r-arrow

image

jdblischak commented 4 weeks ago

And this is discouraging:

https://github.com/conda-forge/r-arrow-feedstock/pulls

image

johnkerl commented 4 weeks ago

@mojaveazure do we really need 15? or will 14 do? (On one of my EC2 instances I have 14 & all is well ...)

jdblischak commented 4 weeks ago

I sent a PR upstream to r-arrow-feedstock to build 15.0.1 for linux and macOS (https://github.com/conda-forge/r-arrow-feedstock/pull/80). Recent updates have been blocked due to failing Windows builds

mojaveazure commented 4 weeks ago

From https://github.com/single-cell-data/TileDB-SOMA/pull/2678

S3 method dimnames() on Arrow objects, refined in Arrow 15.0.0

I remember times where dimnames() on Arrow objects under Arrow 14 wasn't working the way I expected, but do work reliably under Arrow >= 15

johnkerl commented 4 weeks ago

OK thanks @mojaveazure ! Just for general awareness tiledbsoma is non-releasable (there can be no 1.12.0) until we resolve this one way or another.

jdblischak commented 4 weeks ago

Just for general awareness tiledbsoma is non-releasable (there can be no 1.12.0) until we resolve this one way or another.

Worse case scenario we can fork r-arrow-feedstock to TileDB-Inc and upload r-arrow binaries to the tiledb channel

Status update on my upstream PR: I have managed to build r-arrow 16.1.0 for linux and macOS https://github.com/conda-forge/r-arrow-feedstock/pull/80#issuecomment-2148362809

github-actions[bot] commented 4 weeks ago

Nightly feedstock build failure for tiledbsoma-feedstock at https://dev.azure.com/TileDB-Inc/CI/_build?definitionId=43&_a=summary

github-actions[bot] commented 3 weeks ago

Nightly feedstock build failure for tiledbsoma-feedstock at https://dev.azure.com/TileDB-Inc/CI/_build?definitionId=43&_a=summary

jdblischak commented 3 weeks ago

Still failing due to insufficient minimum version of r-arrow. My PR upstream (https://github.com/conda-forge/r-arrow-feedstock/pull/80) hasn't gained any traction yet

johnkerl commented 3 weeks ago

@mojaveazure I believe you when you recall

I remember times where dimnames() on Arrow objects under Arrow 14 wasn't working the way I expected, but do work reliably under Arrow >= 15

-- however our CI here, cloud deployments, etc have demonstrably survived before attempting this pin to arrow >= 15.

I believe this suggests that, for our environment here, an arrow >= 14 might not be entirely inappropriate.

mojaveazure commented 3 weeks ago

Then by all means let's relax the pin; I'll happily approve a PR as soon as a notification hits me

jdblischak commented 3 weeks ago

Last night's build passed because the minimum required r-arrow version was reduced to 14.0.0 in https://github.com/single-cell-data/TileDB-SOMA/pull/2690. Thanks @johnkerl!

jdblischak commented 2 weeks ago

Update: conda-forge now has r-arrow 16.1.0 for linux-64, linux-aarch64, osx-64, and osx-arm64 (https://github.com/conda-forge/r-arrow-feedstock/pull/80)