TileDB-Inc / tiledbsoma-feedstock

A conda-smithy repository for tiledbsoma.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

TileDB-SOMA 1.2.5 #26

Closed johnkerl closed 1 year ago

johnkerl commented 1 year ago

24 gets us TileDB-SOMA 1.2.4: https://github.com/single-cell-data/TileDB-SOMA/releases/tag/1.2.4

Latest tagged in GitHub, and in PyPI, is 1.2.5: https://github.com/single-cell-data/TileDB-SOMA/releases/tag/1.2.5

So this PR will get PyPI and Conda deliverables both on latest-released

The only dependency update here is somacore 1.0.2 -> 1.0.3 but that's handled by https://github.com/TileDB-Inc/tiledbsoma-feedstock/blob/main/recipe/meta.yaml#L103

Tracking: https://github.com/single-cell-data/TileDB-SOMA/issues/1455

jdblischak commented 1 year ago

The only dependency update here is somacore 1.0.2 -> 1.0.3 but that's handled by

How strong is that dependency? Could tiledbsoma-py run with somacore 1.0.2? That would be an allowable configuration according to the conda recipe because it only pins to major.minor (somacore 1.0.*), whereas setup.py pins to major.minor.patch ("somacore==1.0.3")

https://github.com/single-cell-data/TileDB-SOMA/blob/7ade0b7cfe59c75c35f4d8e8bd8586404cae1abd/apis/python/setup.py#L291

johnkerl commented 1 year ago

@jdblischak it's important -- somacore 1.0.3 is part of the deliverables on tiledbsoma-py 1.2.5

I suppose we need a minimum-pin on somacore ... (i.e. I think setup.py is right and should be imitated).

jdblischak commented 1 year ago

somacore 1.0.3 isn't available as a conda binary:

nothing provides somacore >=1.0.3 needed by tiledbsoma-py-1.2.5-py37h0f1fff0_0

Looks like the only somacore release that was built for conda was 1.0.0

https://github.com/TileDB-Inc/somacore-feedstock https://anaconda.org/tiledb/somacore/files

johnkerl commented 1 year ago

Pending https://github.com/TileDB-Inc/somacore-feedstock/pull/2