Closed johnkerl closed 1 year ago
Azure CI failing with
Cloning into bare repository '/home/conda/feedstock_root/build_artifacts/git_cache/github.com/single-cell-data/TileDB-SOMA.git'... git: 'lfs' is not a git command. See 'git --help'.
The problem is the depth. The lfs
message is extraneous:
Cloning into '/Users/runner/miniforge3/conda-bld/tiledbsoma_1687304461900/work'...
checkout: '1c085c51eef6f7b849e6cd3def151afbc5a5ca47'
fatal: reference is not a tree: 1c085c51eef6f7b849e6cd3def151afbc5a5ca47
You have set depth: 1
, but 1c085c51eef6f7b849e6cd3def151afbc5a5ca47 is not the latest commit. I recommend either deleting this field or explicitly set it to -1
(which is the default, and means to perform a full clone of the repo)
TIL @jdblischak -- thanks -- always one more thing to put into my runbook!
That PR affects the numba pin, only for Python 3.11: from 0.57.0rc1 to 0.57.0. However, in this repo's recipe/meta.yaml we have no numba constraints so I don't understand what we do or do not need to do new here.
I had previously raised concern about the the lack of a numba pin. However, I remembered that currently tiledbsoma-py is only built for Python 3.7, 3.8, 3.9, and 3.10
And even conda-forge doesn't yet build for Python 3.11
I skimmed https://github.com/single-cell-data/TileDB-SOMA/issues/1463 and https://github.com/single-cell-data/TileDB-SOMA/pull/1472, but the constraints are not entirely clear to me. Python 3.11 appears to require numba 0.57, which we don't need to worry about in this recipe until we start building binaries for Python 3.11. But what about Python 3.7, 3.8, 3.9, and 3.10? Can they really not work with numba 0.57? If that's the case, then yes, we should add a pin such as numba <0.57
Can they really not work with numba 0.57?
@jdblischak that's not the reason for the 0.57 pin for Python 3.11 only
It was the other way around, in fact -- older numba wouldn't work with Python 3.11, and in fact, we couldn't support tiledbsoma-py
on Python 3.11 at all until numba 0.57.0rc1 came out
Links:
If we aren't doing Python 3.11 in this feedstock repo, and if only Python 3.11 leads to the numba==0.57
constraint, then I'm in favor of not adding any numba constraints right now. (Solving is hard, and the more pins we add, the harder it gets.)
Looking at the release notes for numba 0.57, my understanding is that numba 0.57 is the first to add support for Python 3.11, and that the minimum required version was bumped to Python 3.8. Thus for the purposes of this recipe, we could update the numba
pin to enforce that Python 3.7 requires numba < 0.57. However, one could reasonably argue that this is overkill. Since numba 0.57 dropped support for Python 3.7, conda-forge obviously isn't building a binary for this combination (in fact it has dropped automatic support for Python 3.7, and feedstocks have to opt-in to continue building for Python 3.7 like we have for tiledbsoma-py).
If we aren't doing Python 3.11 in this feedstock repo, and if only Python 3.11 leads to the numba==0.57 constraint, then I'm in favor of not adding any numba constraints right now. (Solving is hard, and the more pins we add, the harder it gets.)
@johnkerl agreed
Another note: I haven't re-renedered yet but I will attempt to check to see if we need to re-render.
I rerendered locally to test. The only update was dropping the R 4.1 build. As long at the R 4.1 build continues to succeed, I see no rush to remove it (and thus recommend skipping rerendering for this release)
Also, I confirmed in the linux-64 build that the locally built libtiledbsoma was always installed when solving the environments to build the API clients (ie the recent addition of {{ pin_subpackage('libtiledbsoma', exact=True) }}
to the host requirements is continuing to work as expected)
Following our currently established procedure at https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases
As always (please see the above wiki) this isn't to be released but rather to check the feasibility of tagging a release.
Food for thought: The four PRs at the tip of https://github.com/single-cell-data/TileDB-SOMA/commits/release-1.2 as of today are all app-level -- and as such shouldn't affect package pins -- except for https://github.com/single-cell-data/TileDB-SOMA/pull/1484/files. That PR affects the
numba
pin, only for Python 3.11: from 0.57.0rc1 to 0.57.0. However, in this repo'srecipe/meta.yaml
we have nonumba
constraints so I don't understand what we do or do not need to do new here.Another note: I haven't re-renedered yet but I will attempt to check to see if we need to re-render.