TileDB-Inc / tiledbsoma-feedstock

A conda-smithy repository for tiledbsoma.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

tiledbsoma 1.4.1 #41

Closed johnkerl closed 1 year ago

johnkerl commented 1 year ago

Render info:

$ conda smithy rerender --commit auto
...
INFO:conda_smithy.configure_feedstock:Re-rendered with conda-build 3.25.0, conda-smithy 3.24.1, and conda-forge-pinning 2023.08.15.13.25.15
INFO:conda_smithy.configure_feedstock:No changes made. This feedstock is up-to-date.
jdblischak commented 1 year ago

Two questions:

  1. Are we skipping the test PR because this is patch version update?
  2. Unless this is super urgent, what about rebasing this on top of PR #38? Merging them together would save CI time overall (and fewer conda artifacts to store)
johnkerl commented 1 year ago

Are we skipping the test PR because this is patch version update?

Yes, there was so very little to possibly go wrong

Unless this is super urgent

@Shelnutt2 wanted this sooner than latter

jdblischak commented 1 year ago

It looks the R package version wasn't bumped to 1.4.1. It's still at 1.4.0, and the conda recipe now uses a single version for libtiledbsoma and the Python/R clients

https://github.com/single-cell-data/TileDB-SOMA/blob/1.4.1/apis/r/DESCRIPTION#L7

johnkerl commented 1 year ago

@jdblischak I'll do a 1.4.2 with a test PR then.

jdblischak commented 1 year ago

I'll do a 1.4.2 with a test PR then.

I wasn't arguing for a test PR (that is totally your decision). I was only requesting either 1) the R version be synced, or 2) we decouple the R version again in the conda recipe

johnkerl commented 1 year ago

I wasn't arguing for a test PR (that is totally your decision)

We are on the same page :)

I was only requesting either 1) the R version be synced, or 2) we decouple the R version again in the conda recipe

As a team we have decided to forevermore sync all language versions in this package (so option 2 is out). And tags are immutable. And GitHub tag 1.4.1 has 1.4.0 in apis/r/DESCRIPTION. So this means necessarily a 1.4.2 (option 1).

johnkerl commented 1 year ago

@jdblischak https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases/_compare/bb544e2d017bb8fd7fad2e8afa6cdbc49da50c29...3c5ce25f805678b139723508e8100d0e23497862