search

TileDB-Inc / tiledbsoma-feedstock

A conda-smithy repository for tiledbsoma.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Make `somacore` dependency exact to match `tiledbsoma` #97

Closed thetorpedodog closed 6 months ago

thetorpedodog commented 6 months ago

A previous version of tiledb-soma erroneously marked itself as compatible with versions of tilebsoma v1.0.8. This is because the PyPI package (https://github.com/single-cell-data/TileDB-SOMA/blob/1.8.0/apis/python/setup.py#L332) lists itself as only compatible with == a version, but this Conda package listed itself as compatible with >= a version.

johnkerl commented 6 months ago

I'll put up a mod

The person who edits recipe/meta.yaml is 99% of the time myself. (See also our established procedure.) Making an exact somacore pin here is an improvement -- it matches TileDB-SOMA's apis/python/setup.py -- but it introduces an error-prone step to be addressed. Namely, the change-me spots in this file are well-highlighted. Similarly the spots that bump regularly including core. The somacore package, by contrast, is "almost invisible" and it tends to disappear in the tiledbsoma shrubbery. A reminder is the right thing to do here.

https://github.com/TileDB-Inc/tiledbsoma-feedstock/pull/97/commits/ebc8814bb449530b52e1c5c4040266257b5853ff