TimOliver / TOCropViewController

A view controller for iOS that allows users to crop portions of UIImage objects
http://www.timoliver.com.au/2015/06/21/tocropviewcontroller-an-open-source-image-cropper-for-ios/
MIT License
4.74k stars 956 forks source link

Accessibility identifier of reset button uses icon name #506

Open honkmaster opened 2 years ago

honkmaster commented 2 years ago

Describe the bug The accessibility identifier of the reset button in the CropViewController read as "arrow.counterclockwise". The other buttons e.g. the rotate right button read as "rotate right". With the reset button, one can assume that the name of the icon is used as the identifier.

To Reproduce Use CropViewController within XCTest.

Expected behavior The accessibility identifier should read as "reset" or similar. It would be even better if the identifier was something like "cropViewController.buttons.reset" and the accessibility label "reset".

Screenshots If applicable, add screenshots to help explain your problem.

iOS Device: Does not apply.

Additional context Add any other context about the problem here.