search

TimothyMeadows / ChaCha20.NetCore

Implementation of chacha20 cipher, designed by D. J. Bernstein. Optimized for PinnedMemory and .NET Core.
MIT License
2 stars 0 forks source link

Release build on NuGet #4

Open detunized opened 3 years ago

detunized commented 3 years ago

I tried to benchmark the lib using BenchmarkDotNet against an alternative implementation. I added the packages from NuGet into my project and after I executed the benchmark I got the following warnings:

// Validating benchmarks:
Assembly ChaCha20Benchmark which defines benchmarks references non-optimized PinnedMemory
        If you own this dependency, please, build it in RELEASE.
        If you don't, you can disable this policy by using 'config.With(ConfigOptions.DisableOptimizationsValidator)'.
Assembly ChaCha20Benchmark which defines benchmarks references non-optimized ChaCha20.NetCore
        If you own this dependency, please, build it in RELEASE.
        If you don't, you can disable this policy by using 'config.With(ConfigOptions.DisableOptimizationsValidator)'.

I'm assuming the packages pushed to NuGet are Debug. Would it be possible to push the Release build to NuGet?

TimothyMeadows commented 3 years ago

Yeah, i can get around to this, i think being first releases i tend to release them as debug.

suixin6383 commented 10 months ago

Is this Salsa20 encryption or chacha20; The encrypted ciphertext in other chachacha20 is different from this encrypted ciphertext, with the same key, iv, rounds