search

TinyTerra / ComfyUI_tinyterraNodes

A selection of nodes for Stable Diffusion ComfyUI
GNU General Public License v3.0
421 stars 45 forks source link

xyPlot autocomplete stopped working #103

Closed rjgoif closed 6 months ago

rjgoif commented 6 months ago

At some point today in my xyPlot testing, I noticed that my loader nodes were out of date so I updated the ttn package. Since then, autocomplete hasn't worked in the xyPlot boxes. I tried restarting Comfy and refreshing the page, but that didn't work.

I see in the readme that there is a setting to toggle somewhere, but I cannot find that with searching various menus. Did autocomplete just break or am I the broken one?

TinyTerra commented 6 months ago

the xyplot autocomplete is seperate to the general autocomplete, so the setting (in the config.ini file) wouldnt change it anyway..

The xyPlot node needs to be connected to a KSampler for the popup to show as well, otherwise it doesn't know which nodes to show info for. Which could be the case, or there might be something else going on..

rjgoif commented 6 months ago

I re-installed and updated my template saves and it started working.

Whatever it was, it probably had to do with the recent updates not jiving with my saved template versions.

Closing as resolved. Thank you!

rjgoif commented 6 months ago

Ah. re-opening! I found the problem. It has to do with logic nodes, specifically when they are hooked up to a node that can be modified by the xyPlot downstream of an IF gate. Here's an example where it fails:

broken workflow

I can't get it to fail 100% with all logic nodes. It seems like it is more likely to stop doing autocomplete when there are more complicated upstream comparisons.

TinyTerra commented 6 months ago

It was being caused by nodes without widgets, should be fixed now :)

rjgoif commented 6 months ago

Nice work!