search

TinyTerra / ComfyUI_tinyterraNodes

A selection of nodes for Stable Diffusion ComfyUI
GNU General Public License v3.0
377 stars 41 forks source link

pipeLoader: Different outputs on SDXL compared to a default workflow #16

Closed diaopal closed 1 year ago

diaopal commented 1 year ago

Tried with pipeLoader + pipeKSampler and pipeLoader + Ksampler, same issue.

You might need to restart ComfyUI after runnning through pipeLoader to test the default workflow since it'll get really slow. Not sure if that's a TTN or ComfyUI bug.

Here is a workflow you can copy-paste into ComfyUI. ```json { "last_node_id": 16, "last_link_id": 44, "nodes": [ { "id": 5, "type": "KSampler", "pos": [ 500, 820 ], "size": [ 315, 446.00001525878906 ], "flags": {}, "order": 7, "mode": 0, "inputs": [ { "name": "model", "type": "MODEL", "link": 26 }, { "name": "positive", "type": "CONDITIONING", "link": 17 }, { "name": "negative", "type": "CONDITIONING", "link": 16 }, { "name": "latent_image", "type": "LATENT", "link": 30 }, { "name": "seed", "type": "INT", "link": 32, "widget": { "name": "seed", "config": [ "INT", { "default": 0, "min": 0, "max": 18446744073709552000 } ] } } ], "outputs": [ { "name": "LATENT", "type": "LATENT", "links": [ 23 ], "shape": 3, "slot_index": 0 } ], "properties": { "Node name for S&R": "KSampler" }, "widgets_values": [ 206821104632760, "randomize", 50, 5, "dpmpp_2m", "karras", 1 ] }, { "id": 4, "type": "CLIPTextEncode", "pos": [ 60, 1070 ], "size": { "0": 400, "1": 200 }, "flags": { "collapsed": false }, "order": 4, "mode": 0, "inputs": [ { "name": "clip", "type": "CLIP", "link": 29, "slot_index": 0 } ], "outputs": [ { "name": "CONDITIONING", "type": "CONDITIONING", "links": [ 16 ], "shape": 3, "slot_index": 0 } ], "properties": { "Node name for S&R": "CLIPTextEncode" }, "widgets_values": [ "" ] }, { "id": 8, "type": "VAEDecode", "pos": [ 510, 730 ], "size": { "0": 210, "1": 46 }, "flags": {}, "order": 9, "mode": 0, "inputs": [ { "name": "samples", "type": "LATENT", "link": 23 }, { "name": "vae", "type": "VAE", "link": 27 } ], "outputs": [ { "name": "IMAGE", "type": "IMAGE", "links": [ 25 ], "shape": 3, "slot_index": 0 } ], "properties": { "Node name for S&R": "VAEDecode" } }, { "id": 1, "type": "ttN pipeLoader", "pos": [ 60, 30 ], "size": [ 400, 726 ], "flags": {}, "order": 6, "mode": 0, "inputs": [ { "name": "seed", "type": "INT", "link": 42, "widget": { "name": "seed", "config": [ "INT", { "default": 0, "min": 0, "max": 18446744073709552000 } ] }, "slot_index": 0 }, { "name": "positive", "type": "STRING", "link": 34, "widget": { "name": "positive", "config": [ "STRING", { "default": "Positive", "multiline": true } ] } } ], "outputs": [ { "name": "pipe", "type": "PIPE_LINE", "links": [ 1 ], "shape": 3, "slot_index": 0 }, { "name": "model", "type": "MODEL", "links": [], "shape": 3, "slot_index": 1 }, { "name": "positive", "type": "CONDITIONING", "links": [], "shape": 3, "slot_index": 2 }, { "name": "negative", "type": "CONDITIONING", "links": [], "shape": 3, "slot_index": 3 }, { "name": "latent", "type": "LATENT", "links": [], "shape": 3, "slot_index": 4 }, { "name": "vae", "type": "VAE", "links": [], "shape": 3, "slot_index": 5 }, { "name": "clip", "type": "CLIP", "links": [], "shape": 3 }, { "name": "seed", "type": "INT", "links": [], "shape": 3, "slot_index": 7 } ], "properties": { "Node name for S&R": "ttN pipeLoader" }, "widgets_values": [ "sd_xl_base_1.0.safetensors", "Baked VAE", -1, "None", 1, 1, "None", 1, 1, "None", 1, 1, "Astronaut in a jungle, (cold color palette:1.2), muted colors, detailed, 8k\n", "none", "comfy", "", "none", "comfy", 1024, 1024, 1, 42, "fixed" ] }, { "id": 10, "type": "EmptyLatentImage", "pos": [ -350, 1100 ], "size": { "0": 315, "1": 106 }, "flags": {}, "order": 0, "mode": 0, "outputs": [ { "name": "LATENT", "type": "LATENT", "links": [ 30 ], "shape": 3, "slot_index": 0 } ], "properties": { "Node name for S&R": "EmptyLatentImage" }, "widgets_values": [ 1024, 1024, 1 ] }, { "id": 9, "type": "CheckpointLoaderSimple", "pos": [ -350, 950 ], "size": { "0": 315, "1": 98 }, "flags": {}, "order": 1, "mode": 0, "outputs": [ { "name": "MODEL", "type": "MODEL", "links": [ 26 ], "shape": 3, "slot_index": 0 }, { "name": "CLIP", "type": "CLIP", "links": [ 28, 29 ], "shape": 3, "slot_index": 1 }, { "name": "VAE", "type": "VAE", "links": [ 27 ], "shape": 3, "slot_index": 2 } ], "properties": { "Node name for S&R": "CheckpointLoaderSimple" }, "widgets_values": [ "sd_xl_base_1.0.safetensors" ] }, { "id": 12, "type": "PrimitiveNode", "pos": [ -350, 770 ], "size": [ 310, 130 ], "flags": {}, "order": 2, "mode": 0, "outputs": [ { "name": "STRING", "type": "STRING", "links": [ 33, 34 ], "widget": { "name": "text", "config": [ "STRING", { "multiline": true } ] }, "slot_index": 0 } ], "properties": {}, "widgets_values": [ "Astronaut in a jungle, (cold color palette:1.2), muted colors, detailed, 8k\n" ] }, { "id": 7, "type": "PreviewImage", "pos": [ 830, 830 ], "size": { "0": 210, "1": 26 }, "flags": {}, "order": 11, "mode": 0, "inputs": [ { "name": "images", "type": "IMAGE", "link": 25 } ], "properties": { "Node name for S&R": "PreviewImage" } }, { "id": 11, "type": "PrimitiveNode", "pos": [ -220, 340 ], "size": { "0": 210, "1": 82 }, "flags": {}, "order": 3, "mode": 0, "outputs": [ { "name": "INT", "type": "INT", "links": [ 32, 42 ], "widget": { "name": "seed", "config": [ "INT", { "default": 0, "min": 0, "max": 18446744073709552000 } ] }, "slot_index": 0 } ], "properties": {}, "widgets_values": [ 42, "fixed" ] }, { "id": 3, "type": "CLIPTextEncode", "pos": [ 113, 842 ], "size": [ 210, 50 ], "flags": { "collapsed": false }, "order": 5, "mode": 0, "inputs": [ { "name": "clip", "type": "CLIP", "link": 28, "slot_index": 0 }, { "name": "text", "type": "STRING", "link": 33, "widget": { "name": "text", "config": [ "STRING", { "multiline": true } ] }, "slot_index": 1 } ], "outputs": [ { "name": "CONDITIONING", "type": "CONDITIONING", "links": [ 17 ], "shape": 3, "slot_index": 0 } ], "properties": { "Node name for S&R": "CLIPTextEncode" }, "widgets_values": [ "Astronaut in a jungle, (cold color palette:1.2), muted colors, detailed, 8k\n" ] }, { "id": 2, "type": "ttN pipeKSampler", "pos": [ 490, 30 ], "size": [ 330, 622 ], "flags": {}, "order": 8, "mode": 0, "inputs": [ { "name": "pipe", "type": "PIPE_LINE", "link": 1 }, { "name": "optional_model", "type": "MODEL", "link": null }, { "name": "optional_positive", "type": "CONDITIONING", "link": null }, { "name": "optional_negative", "type": "CONDITIONING", "link": null }, { "name": "optional_latent", "type": "LATENT", "link": null }, { "name": "optional_vae", "type": "VAE", "link": null }, { "name": "optional_clip", "type": "CLIP", "link": null }, { "name": "xyPlot", "type": "XYPLOT", "link": null }, { "name": "seed", "type": "INT", "link": null, "widget": { "name": "seed", "config": [ "INT", { "default": 0, "min": 0, "max": 18446744073709552000 } ] } } ], "outputs": [ { "name": "pipe", "type": "PIPE_LINE", "links": null, "shape": 3 }, { "name": "model", "type": "MODEL", "links": null, "shape": 3 }, { "name": "positive", "type": "CONDITIONING", "links": null, "shape": 3 }, { "name": "negative", "type": "CONDITIONING", "links": null, "shape": 3 }, { "name": "latent", "type": "LATENT", "links": null, "shape": 3 }, { "name": "vae", "type": "VAE", "links": null, "shape": 3 }, { "name": "clip", "type": "CLIP", "links": null, "shape": 3 }, { "name": "image", "type": "IMAGE", "links": [ 21 ], "shape": 3, "slot_index": 7 }, { "name": "seed", "type": "INT", "links": null, "shape": 3 } ], "properties": { "Node name for S&R": "ttN pipeKSampler" }, "widgets_values": [ "None", 1, 1, "None", 2, "disabled", "Sample", 50, 5, "dpmpp_2m", "karras", 1, "Preview", "ComfyUI", 614447616870507, "randomize" ] }, { "id": 6, "type": "PreviewImage", "pos": [ 850, 30 ], "size": [ 210, 246 ], "flags": {}, "order": 10, "mode": 0, "inputs": [ { "name": "images", "type": "IMAGE", "link": 21 } ], "properties": { "Node name for S&R": "PreviewImage" } } ], "links": [ [ 1, 1, 0, 2, 0, "PIPE_LINE" ], [ 16, 4, 0, 5, 2, "CONDITIONING" ], [ 17, 3, 0, 5, 1, "CONDITIONING" ], [ 21, 2, 7, 6, 0, "IMAGE" ], [ 23, 5, 0, 8, 0, "LATENT" ], [ 25, 8, 0, 7, 0, "IMAGE" ], [ 26, 9, 0, 5, 0, "MODEL" ], [ 27, 9, 2, 8, 1, "VAE" ], [ 28, 9, 1, 3, 0, "CLIP" ], [ 29, 9, 1, 4, 0, "CLIP" ], [ 30, 10, 0, 5, 3, "LATENT" ], [ 32, 11, 0, 5, 4, "INT" ], [ 33, 12, 0, 3, 1, "STRING" ], [ 34, 12, 0, 1, 1, "STRING" ], [ 42, 11, 0, 1, 0, "INT" ] ], "groups": [], "config": {}, "extra": {}, "version": 0.4 } ```
TinyTerra commented 1 year ago

I believe the default comfy clip encoder uses a -2 clip skip, which is where the difference is :) Just tried it now and got the same result for both

diaopal commented 1 year ago

Oh that's why! ComfyUI defaults to -2 for SDXL clips. Thanks