search

TinyTerra / ComfyUI_tinyterraNodes

A selection of nodes for Stable Diffusion ComfyUI
GNU General Public License v3.0
422 stars 45 forks source link

rembg[gpu] package doesn't install on Mac OS X M1 ARM #24

Closed WingTangWong closed 1 year ago

WingTangWong commented 1 year ago

On first run, I get this error:

ERROR: Cannot install rembg[gpu]==2.0.28, rembg[gpu]==2.0.29, rembg[gpu]==2.0.30, rembg[gpu]==2.0.31, rembg[gpu]==2.0.32, rembg[gpu]==2.0.33, rembg[gpu]==2.0.34, rembg[gpu]==2.0.35, rembg[gpu]==2.0.36, rembg[gpu]==2.0.37, rembg[gpu]==2.0.38, rembg[gpu]==2.0.39, rembg[gpu]==2.0.40, rembg[gpu]==2.0.41, rembg[gpu]==2.0.43, rembg[gpu]==2.0.44, rembg[gpu]==2.0.45, rembg[gpu]==2.0.46, rembg[gpu]==2.0.47, rembg[gpu]==2.0.48, rembg[gpu]==2.0.49 and rembg[gpu]==2.0.50 because these package versions have conflicting dependencies.

Does not stop the server from starting, but was able to install rembg==2.0.50 manually. Unless rembg[gpu] supports Mac M1 MPS or MLS or similar, might be better to have the startup determine the system it is running on and install the rembg as appopriate or have it fallback to a non-gpu version?

TinyTerra commented 1 year ago

Interesting - rembg in general has quite a few issues especially with installing correctly... good idea to add the fallback though

TinyTerra commented 1 year ago

I've added a rembg[gpu] to rembg fallback in f835f0f852a299f92d793e091debebffcb2f7ece