TinyTerra / ComfyUI_tinyterraNodes

A selection of nodes for Stable Diffusion ComfyUI
GNU General Public License v3.0
397 stars 45 forks source link

Missing TTN options on node menu #39

Closed WinstonWoof closed 1 year ago

WinstonWoof commented 1 year ago

Completely lost all TTN options on node menu when upgrading .

Even wiped completly and did full clean install.

In end reverted to older version

CaptainGrock commented 1 year ago

Duplicated issue - can't access these nodes

GalaxyTimeMachine commented 1 year ago

Same

TinyTerra commented 1 year ago

Is there any error log when launching comfy? Do the nodes fail to import, or is it just the JavaScript node options?

GalaxyTimeMachine commented 1 year ago

If you saw it, please ignore the previously reported error log from me, it was something I'd changed that caused that. I've just deleted the ttN folder and re-cloned it, and I can now see the nodes in the menu. image image

WinstonWoof commented 1 year ago

Is there any error log when launching comfy? Do the nodes fail to import, or is it just the JavaScript node options?

no error, just MIA

soulctcher commented 1 year ago

This is still an issue and I've removed and re-pulled the ttn repo. This is what's causing the failure during import on launch of ComfyUI:

Traceback (most recent call last):
  File "C:\Users\soulc\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1694, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "C:\Users\soulc\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_tinyterraNodes\__init__.py", line 1, in <module>
    from .tinyterraNodes import TTN_VERSIONS
  File "C:\Users\soulc\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_tinyterraNodes\tinyterraNodes.py", line 27, in <module>
    from comfy.model_patcher import ModelPatcher
ModuleNotFoundError: No module named 'comfy.model_patcher'

Cannot import C:\Users\soulc\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_tinyterraNodes module for custom nodes: No module named 'comfy.model_patcher'
TinyTerra commented 1 year ago

Please update ComfyUI using the update batch file, and check if this is still occurring.

A recent comfy update changed how certain code needed to be imported, and the current version of tinyterraNodes is no longer compatible with earlier versions of comfy ui before these changes

soulctcher commented 1 year ago

Looks like I had a stuck modification...forced a reset to the current comfyui commit and that resolved the issue. Thanks @TinyTerra for your great work.