TinyTerra / ComfyUI_tinyterraNodes

A selection of nodes for Stable Diffusion ComfyUI
GNU General Public License v3.0
397 stars 45 forks source link

textDebug not showing text inside the node #46

Closed alessandroperilli closed 1 year ago

alessandroperilli commented 1 year ago

The textDebug node is very useful, thank you. I'm using it to verify that my very simple prompt builder is working as expected:

Screenshot 2023-09-03 at 08 50 04

Before your last commit, this setup would show the text concat both inside the node and in the terminal. After the commit, the concat only appears in the terminal. The node remains always empty.

Side note: the terminal print only appears when I modify the prompt, rather than at each generation. It would be nice if it could print the text at each generation.

Thank you

WinstonWoof commented 1 year ago

I'm seeing the same issue however only post a Core ComfyUI update

https://github.com/comfyanonymous/ComfyUI/issues/1397

WinstonWoof commented 1 year ago

@alessandroperilli

The answer to the question re CHatGPT nodes is Omar92's QOL

https://github.com/omar92/ComfyUI-QualityOfLifeSuit_Omar92

There's a demo workflow in mine

https://civitai.com/user/Winston_Woof/models

TinyTerra commented 1 year ago

This should be fixed in 0d76921beca2d09ac8c0e29382f806aa4c7cd560 :)

alessandroperilli commented 1 year ago

It's great to see the new Execute option, but I'm afraid the bug is still there, @TinyTerra:

Screenshot 2023-09-18 at 10 12 39

Given that you are looking into this, I'll sneak in a feat request, if you don't mind: if you could add a text to append, it would be great.

Desired behaviour:

Happy to open a dedicated issue for this feat request, if it helps.

TinyTerra commented 1 year ago

Apologies... the preview text should be fixed in f1d942d038d3b91def93b2fae893d6b88dceb100. I've also added console_title that overrides the default 'input' console prefix.

And fixed the default behaviour (empty consoletitle) to use the label instead of the name of the output slot if it has been changed. (If you rename the output slot of the inputting node it should now use the users label instead of the default value)_

image

image

alessandroperilli commented 1 year ago

Fixed and improved massively. Thank you!

alessandroperilli commented 1 year ago

Ignore me.

WinstonWoof commented 1 year ago

apologies for the delay, Been having a nice city break in Prague :)

Yup all working as expected again, cheers