Lora name in XY Plot doesn't handle spaces correctly

TinyTerra / ComfyUI_tinyterraNodes

A selection of nodes for Stable Diffusion ComfyUI

GNU General Public License v3.0

341 stars 41 forks source link

Lora name in XY Plot doesn't handle spaces correctly #76

Closed Dagbafrosty closed 2 months ago

Dagbafrosty commented 8 months ago

It seems like the autocomplete functionality doesn't like loras with spaces in their name. Selecting the autocomplete or making a typo after typing a space (such that there are no suggestions remaining) causes that entry to get removed. A lora with a space can be forced accepted by converting x value to input and passing the full name in a primitive.

One more thing is the model&clip shouldn't be capped at 4, there are some loras designed to use weights upto 7-9.

TinyTerra commented 8 months ago

Yup, working on improving xyplot for the next update. Not too sure when that will be though

TinyTerra commented 2 months ago

V2 has added advanced xyPlot for pipeLoader_v2 and pipeLoaderSDXL_v2. There is some more detail about how it works in the readme. The old xyplot has now been deprecated