search

TinyTerra / ComfyUI_tinyterraNodes

A selection of nodes for Stable Diffusion ComfyUI
GNU General Public License v3.0
332 stars 39 forks source link

The Fullscreen keybinding should be changed #80

Closed Immac closed 5 months ago

Immac commented 6 months ago

shift + up is a very common binding when editing text (select text upwards), I find myself going fullscreen a lot of the time due to this, check usual keyboard shortcuts and appropriately change it, if possible something like modifier + f11 could be a better key bind.

hitrpr commented 5 months ago

Agree, i hate it, because it switches on when I edit prompt and want to select. It should not conflict to any editing key.

Also the hotkey can be still one-handeld, like shift+f3 or shift+F11

ATM the only way to fix it — change tttnfullscreen.js at str 211 and set «read only» attr to file to be sure, it will not be rewritten. was: if ((e.code === 'ArrowUp' && e.shiftKey) && !e.ctrlKey) { fixed: if ((e.code === 'F11' && e.shiftKey) && !e.ctrlKey) {

hitrpr commented 5 months ago

okay, i made pull request for this change, let`s wait

TinyTerra commented 5 months ago

Merged the pull request