search

TinyTerra / ComfyUI_tinyterraNodes

A selection of nodes for Stable Diffusion ComfyUI
GNU General Public License v3.0
332 stars 39 forks source link

Suggestion: Put positive and negative strings in the PIPE #94

Closed cjps-br closed 2 months ago

cjps-br commented 3 months ago

the strings that generate positive and negative conditioning could also be part of the pipe and also be available as outputs in both pipeLoader and pipeKSampler

TinyTerra commented 3 months ago

This will be coming in v2, which should hopefully be out soon, I just need to do some polishing before releasing it

TinyTerra commented 2 months ago

pos_string and neg_string have been added to pipeKSampler_v2 and pipeKSamplerSDXL_v2 in (cfaecd01e7f3547b38c7e44f417655471a6b181a)

cjps-br commented 2 months ago

pos_string and neg_string have been added to pipeKSampler_v2 and pipeKSamplerSDXL_v2 in (cfaecd0)

I did some tests and verified that the "pos_string" output only receives the value of the positive field. If there is text being informed by the prepend_positive input, it is considered in the image conditioning, but its value is not placed in the "pos_string" output. the same observation applies to the negative fields.

Attached I include images that I used for testing (with the workflow embedded in them)

base base_with_positive base_with_positive_as_input

TinyTerra commented 2 months ago

Ah of course, sorry. That was an oversight Should be fixed in 2b64695debe546e3c0e4b52bff13b620b0a87834