search

TinyTerra / ComfyUI_tinyterraNodes

A selection of nodes for Stable Diffusion ComfyUI
GNU General Public License v3.0
332 stars 39 forks source link

Question around pipesampler op order / possibly unwanted behavior #97

Open pm5k opened 2 months ago

pm5k commented 2 months ago

Hello,

I noticed that when you have two pipe samplers connected together, previews they churn out do not update between the sampler runs in order, instead they update at the end like so:

https://github.com/TinyTerra/ComfyUI_tinyterraNodes/assets/9250112/095d40b0-45a4-4de9-a9f4-6c90d880e5d8

This is not something that occurs with other samplers for instance:

https://github.com/TinyTerra/ComfyUI_tinyterraNodes/assets/9250112/7a1aaaa1-6d4a-4f27-985b-8d20915eb8ce

Is this intended behaviour, bug or is this a user skill issue?

TinyTerra commented 2 months ago

Strange behavior.... It seems to be dependent on the node creation order, if you delete the second ksamp and remake it the previews will update correctly.

You can also set 'Image_output' to 'Preview' in the pipekSampler itself to remove the need for the extra node

pm5k commented 2 months ago

The demo videos I have shown are freshly created samplers in sequence, they do not update the way you suggest after remaking either. The "hanging" behaviour stays the same sadly.

I do appreciate that the samplers themselves have a preview, but that's of little use to me as my actual workflow is a lot more complex with previews all being moved into a sequential space in the graph where I can observe them side by side so having them as separate nodes is advantageous. A lot of the generative work I do ends up with lots of object detail as it is concept art based. Anyway, if you can think of why this behaviour is present, it would be nice to see a solution. Let me know if I can provide more repro material for you. Otherwise if you don't think you will have time, you can close this issue

TinyTerra commented 2 months ago

Something very strange happening with the execution order..

I don't have time currently, but I'll have a look into it a bit further when i do.

pm5k commented 2 months ago

It COULD be also something with cross-extension behavior. I would not worry too much it sounds to me like a needle in the haystack. I reinstalled your nodes and the issue went away, then reappeared and then went away again. God knows what this is. If you fancy a crack at it, go for it, but please don't treat it with urgency, I have found some workarounds.