search

TobiasWooldridge / UniBuddyTimetable

http://timetable.unibuddy.com.au
GNU Affero General Public License v3.0
9 stars 5 forks source link

Filter for topics is unbearably slow #27

Closed TobiasWooldridge closed 10 years ago

TobiasWooldridge commented 10 years ago

On PCs and tablets, the filter for topics is FAR too slow.

Perhaps we should delay the filtering by keypresses?

Or not display anything if there are more than 100 topics.

Suggestions?

rdpeake commented 10 years ago

examples that demonstrate the 'slowness'?

does my new search function alter this, (this is still on my git as i've not fully tested it)

Daniel15 commented 10 years ago

Something calling jQuery's .text() method somewhere is taking up quite a bit of CPU time: screen shot 2013-11-15 at 8 24 55 pm

It's a bit faster if I totally remove jQuery so perhaps a component is being rendered inefficiently.

This is not AngularJS itself as Angular doesn't use jQuery directly.

TobiasWooldridge commented 10 years ago

Steps for replication:

  1. Open page.
  2. Type something in filter.
  3. Observe that it is slow :P

If it's not immediately obvious, try this on a tablet, slower PC or internet explorer. Once you notice it you can't not notice it

TobiasWooldridge commented 10 years ago

Fixed for now, mainly by limiting number of topics in select field